![]() ![]() implies that the legacy ABI was used only for WinCE. Do you know what "others" refers to so the comment can be updated? (Or even the line removed if others=nothing supported and so now unnecessary): Regarding this bug, I believe I've almost finished the patch, I just have a few questions on some stragglers:ġ) Can these three lines be removed? ie: It would appear to be build error fixes specific to WINMO, but wanted to check.Ģ) The comment on this line refers to "wince and some others". I'll send the reply to this off-bug, as it ended up being long enough to take this considerably off topic! :-) > We were thinking of deleting all the and starting again. Great - thought that was possibly the case just wanted to be sure (especially given the comments in bug 614720 too) before embarking on a patch. > not the best use of time for someone already familiar with the codebase. > I think (and I hope I'm not putting words in Jeff's mouth) that he means it's ![]() ![]() I'll also personally find you a speedy review and handle the checkin. Assuming no issues come up, I'd say there's a 99% chance of this getting in. This change is wanted - and there are dozens more like it (preprocessor symbols which, when turned either on or off, wont build, and won't be resurrected either). > sure whether a patch is going to be accepted please. > future (given that the changes would touch 34 files), can someone confirm for Before I start a patch that could end up bit-rotting for the foreseeable > However I'm struggling to tell from the above whether this change is wanted or We were thinking of deleting all the and starting again. > Many of the bugs marked are out of date or else are actually > correctly formatted patches and the review process/checkin process.Įxcellent! That's why I wrote this one up. > - but at least mean I can get familiar with the codebase, using hg/exporting > grips with C), these kind of bugs are the only ones I can tackle at this stage > As a newcomer to the gecko codebase (and as someone who is still getting to I think (and I hope I'm not putting words in Jeff's mouth) that he means it's not the best use of time for someone already familiar with the codebase. Before I start a patch that could end up bit-rotting for the foreseeable future (given that the changes would touch 34 files), can someone confirm for sure whether a patch is going to be accepted please. However I'm struggling to tell from the above whether this change is wanted or not. As such after spotting this potentially easy bug in the list, I was hoping that I would be able to take it on. Many of the bugs marked are out of date or else are actually not beginner level bugs, but those that owners do not wish to do themselves. > improvements I'd rather do, or see done, before this one.Īs a newcomer to the gecko codebase (and as someone who is still getting to grips with C), these kind of bugs are the only ones I can tackle at this stage - but at least mean I can get familiar with the codebase, using hg/exporting correctly formatted patches and the review process/checkin process. I agree that "never will again" is a bit strong. ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |